From: Will Thompson Date: Tue, 25 Sep 2018 22:00:53 +0000 (+0100) Subject: workspacesView: initialize self._restackedNotifyId X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~929^2^2~28 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=b2fabd935637126e7a8d00b11f918776e742280a;p=gnome-shell.git workspacesView: initialize self._restackedNotifyId This attribute was previously only assigned in show(). hide() compares this attribute to 0. If hide() is called before show() is first called, the comparison would give the correct result (undefined > 0 is false) but log a warning: JS WARNING: [resource:///org/gnome/shell/ui/workspacesView.js 529]: reference to undefined property "_restackedNotifyId" Initialize this attribute in _init(), alongside _scrollEventId and _keyPressEventId which are also used in hide(). --- diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js index 4ba8db754..4c97094aa 100644 --- a/js/ui/workspacesView.js +++ b/js/ui/workspacesView.js @@ -481,6 +481,7 @@ var WorkspacesDisplay = new Lang.Class({ this._switchWorkspaceNotifyId = 0; this._notifyOpacityId = 0; + this._restackedNotifyId = 0; this._scrollEventId = 0; this._keyPressEventId = 0;